Skip to content

central_systest_blobs: sort hashsets when dumping#13968

Open
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_implement_blob_creation_from_blocksfrom
04-30-central_systest_blobs_sort_hashsets_when_dumping
Open

central_systest_blobs: sort hashsets when dumping#13968
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_implement_blob_creation_from_blocksfrom
04-30-central_systest_blobs_sort_hashsets_when_dumping

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk: changes are confined to test blob/fixture serialization and expected resource files to make JSON output deterministic.

Overview
Makes central_systest_blobs JSON fixtures stable by adding a normalization step that sorts specific HashSet-backed array fields before pretty-printing (normalize_set_arrays/to_normalized_json).

Updates the regression test and GCS upload path to use the normalized JSON output (and adjusts the blobs upload function to take ownership of blobs), bumps the stored blob generation, and refreshes preconfirmed_block.json to match the new deterministic formatting/order; adds serde as a dev-dependency.

Reviewed by Cursor Bugbot for commit 1b7ea13. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_blob_creation_from_blocks branch from c0d0ac9 to 0e56d10 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from f9cb358 to 24bca91 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from 24bca91 to caa4531 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_blob_creation_from_blocks branch from 0e56d10 to 99fd2d7 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from caa4531 to 54e47dc Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_blob_creation_from_blocks branch from 99fd2d7 to 35f0f1b Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_implement_blob_creation_from_blocks branch from 35f0f1b to 9c6fcc0 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from 54e47dc to 1b7ea13 Compare May 5, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants