Skip to content

central_systest_blobs: expect operator and fee token addresses#13973

Open
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_deploy_token_contractfrom
04-30-central_systest_blobs_expect_operator_and_fee_token_addresses
Open

central_systest_blobs: expect operator and fee token addresses#13973
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_deploy_token_contractfrom
04-30-central_systest_blobs_expect_operator_and_fee_token_addresses

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 5, 2026 11:05
@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Changes are confined to systest regression data generation and golden test fixtures; primary risk is test flakiness or mismatched expected blob artifacts.

Overview
Makes the central systest blob regression deterministic by pinning and asserting the expected operator deploy-account address and the derived ERC20 fee-token contract address.

Updates BlobFactory to build ChainInfo with explicit FeeTokenAddresses, derives the deployed contract address via calculate_contract_address, and returns it from make_operator_deploy_tx for assertion. Regenerates golden fixtures (blob_file_generation, chain_info.json, preconfirmed_block.json) to reflect the new fixed fee token address and resulting receipt gas/fee values.

Reviewed by Cursor Bugbot for commit 230aacb. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from da7b263 to 7e39626 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from 1c6a757 to 05c3328 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from 05c3328 to b7db825 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 7e39626 to 742c842 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from b7db825 to f831a9b Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 742c842 to 9714281 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_expect_operator_and_fee_token_addresses branch from 9714281 to 230aacb Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_token_contract branch from f831a9b to 0f8511a Compare May 5, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants