central_systest_blobs: implement preconfirmed block creation#13964
Conversation
PR SummaryMedium Risk Overview Updates regression fixtures to match the new metadata/output, including bumping the blobs generation marker and adjusting Reviewed by Cursor Bugbot for commit 883b371. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 74bea58. Configure here.
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 2 files and all commit messages, and made 3 comments.
Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 268 at r1 (raw file):
let mut transaction_state_diffs = vec![]; for (tx_index, (executable, internal)) in self.next_txs.iter().enumerate() {
I would expect self.next_txs to be consumed here (i.e taken and replaced with an empty vec).
I think std::mem::take can do that
Code quote:
for (tx_index, (executable, internal)) in self.next_txs.iter().enumerate() {crates/central_systest_blobs/src/cende_blob_regression_test.rs line 276 at r1 (raw file):
}; let mut tx_state = CachedState::new(self.state.clone());
Do you have to use CachedState here? Isn't it better to simply send self.state?
Code quote:
let mut tx_state = CachedState::new(self.state.clone());cfef6e4 to
e018c29
Compare
74bea58 to
eb6fe34
Compare
eb6fe34 to
6115833
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 3 comments and resolved 1 discussion.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on nimrod-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 268 at r1 (raw file):
Previously, nimrod-starkware wrote…
I would expect
self.next_txsto be consumed here (i.e taken and replaced with an empty vec).
I think std::mem::take can do that
nice!
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 276 at r1 (raw file):
Previously, nimrod-starkware wrote…
Do you have to use CachedState here? Isn't it better to simply send
self.state?
I need a way to create a state diff for the tx only. the way to do that is by using a cached state
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 261 at r3 (raw file):
/// Creates a preconfirmed block for the given block. Should be called for the last block only - /// no commitment is computed. fn make_preconfirmed_block_from_remaining_txs(self) -> CendeWritePreconfirmedBlock {
are you sure you should consume self here?
Code quote:
(self)
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on nimrod-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 261 at r3 (raw file):
Previously, nimrod-starkware wrote…
are you sure you should consume self here?
yes, after you make a preconfirmed block from the remaining txs, you shouldn't be producing any more blocks.
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 1 file, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
6115833 to
3ffa587
Compare
e018c29 to
206c9b8
Compare
3ffa587 to
883b371
Compare
Merge activity
|


No description provided.