central_systest_blobs: add some invokes#13978
central_systest_blobs: add some invokes#13978dorimedini-starkware wants to merge 1 commit into05-05-central_systest_blobs_support_reverting_invokesfrom
Conversation
PR SummaryMedium Risk Overview Regenerates the golden artifacts used by the regression test by bumping Reviewed by Cursor Bugbot for commit fd1c2e9. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e8ac2ca. Configure here.
556eda2 to
c05cd6d
Compare
e8ac2ca to
85cd564
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware resolved 1 discussion.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on nimrod-starkware and yoavGrs).
c05cd6d to
c2b98b3
Compare
8bde747 to
c9a7ca9
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 920 at r2 (raw file):
&[Felt::from(7u8), Felt::ONE], true, // charge fee true, // should revert
Suggestion:
should be reverted4b81e80 to
ac488b5
Compare
c9a7ca9 to
015017d
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 920 at r2 (raw file):
&[Felt::from(7u8), Felt::ONE], true, // charge fee true, // should revert
see previous PR: revert is a verb, I think this is fine
ac488b5 to
92a3d78
Compare
015017d to
3700e92
Compare
3700e92 to
fd1c2e9
Compare
92a3d78 to
735123b
Compare


No description provided.