Skip to content

central_systest_blobs: add some invokes#13978

Open
dorimedini-starkware wants to merge 1 commit into05-05-central_systest_blobs_support_reverting_invokesfrom
04-30-central_systest_blobs_add_some_invokes
Open

central_systest_blobs: add some invokes#13978
dorimedini-starkware wants to merge 1 commit into05-05-central_systest_blobs_support_reverting_invokesfrom
04-30-central_systest_blobs_add_some_invokes

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Medium Risk
Updates the systest blob regression dataset and expected preconfirmed_block.json, which can cause downstream snapshot/test mismatches if any consumer assumptions about the generated sequence change.

Overview
Extends test_make_data in cende_blob_regression_test.rs to execute a longer, more varied transaction sequence by adding multiple make_operator_invoke_tx calls (including cross-contract call and an expected revert), and tracks deployed test contract addresses for later invokes.

Regenerates the golden artifacts used by the regression test by bumping resources/blob_file_generation and updating resources/preconfirmed_block.json to match the new preconfirmed block output (block number/timestamp, fees, nonces, calldata, and state diffs).

Reviewed by Cursor Bugbot for commit fd1c2e9. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e8ac2ca. Configure here.

Comment thread crates/central_systest_blobs/src/cende_blob_regression_test.rs
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from 556eda2 to c05cd6d Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch from e8ac2ca to 85cd564 Compare May 5, 2026 11:18
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 1 discussion.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on nimrod-starkware and yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from c05cd6d to c2b98b3 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch 2 times, most recently from 8bde747 to c9a7ca9 Compare May 5, 2026 12:31
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and yoavGrs).


crates/central_systest_blobs/src/cende_blob_regression_test.rs line 920 at r2 (raw file):

        &[Felt::from(7u8), Felt::ONE],
        true, // charge fee
        true, // should revert

Suggestion:

should be reverted

@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from 4b81e80 to ac488b5 Compare May 5, 2026 12:41
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch from c9a7ca9 to 015017d Compare May 5, 2026 12:41
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).


crates/central_systest_blobs/src/cende_blob_regression_test.rs line 920 at r2 (raw file):

        &[Felt::from(7u8), Felt::ONE],
        true, // charge fee
        true, // should revert

see previous PR: revert is a verb, I think this is fine

@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from ac488b5 to 92a3d78 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch from 015017d to 3700e92 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_add_some_invokes branch from 3700e92 to fd1c2e9 Compare May 5, 2026 14:23
@dorimedini-starkware dorimedini-starkware force-pushed the 05-05-central_systest_blobs_support_reverting_invokes branch from 92a3d78 to 735123b Compare May 5, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants