central_systest_blobs: implement block production, given txs#13966
Conversation
PR SummaryMedium Risk Overview Updates the systest blob crate dependencies to enable Reviewed by Cursor Bugbot for commit aecc100. Bugbot is set up for automated code reviews on this repo. Configure here. |
c72a3dc to
31f9d81
Compare
d63278f to
6c9bcb1
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware partially reviewed 3 files and made 5 comments.
Reviewable status: 2 of 3 files reviewed, 5 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 57 at r1 (raw file):
use starknet_api::executable_transaction::{ AccountTransaction as ExecutableAccountTx, DeclareTransaction as ExecutableDeclareTransaction,
Suggestion:
DeclareTransaction as ExecutableDeclareTxcrates/central_systest_blobs/src/cende_blob_regression_test.rs line 85 at r1 (raw file):
use starknet_committer::db::forest_trait::StorageInitializer; use starknet_patricia_storage::map_storage::MapStorage; use starknet_transaction_prover::running::committer_utils::commit_state_diff;
consider moving commit_state_diff into the starknet_committer crate. (not in this PR)
I don't think the depndency in starknet_transaction_prover makes sense here...
Code quote:
use starknet_transaction_prover::running::committer_utils::commit_state_diff;crates/central_systest_blobs/src/cende_blob_regression_test.rs line 156 at r1 (raw file):
/// Executes the unblocked transactions and applies the changes to the state. /// Any subsequent tx added will end up in the next block.
Suggestion:
/// Executes the unblocked transactions and applies the changes to the state.
/// Any subsequent transaction added will end up in the next block.crates/central_systest_blobs/src/cende_blob_regression_test.rs line 197 at r1 (raw file):
execution_info, }); }
same as few PR's before.
shouldn't self.next_txs be consumed using std::mem::take?
Code quote:
for (executable, internal) in self.next_txs.iter() {
let (execution_info, _state_changes) = executor
.execute(&BlockifierTx::new_for_sequencing(ExecutableTx::Account(
executable.clone(),
)))
.unwrap();
assert!(!execution_info.is_reverted(), "Got a reverted tx: {execution_info:?}");
transactions_with_receipts.push(InternalTransactionWithReceipt {
transaction: internal.clone(),
execution_info,
});
}crates/central_systest_blobs/src/cende_blob_regression_test.rs line 255 at r1 (raw file):
state_roots, }); self.next_txs.clear();
see above comment re this.
Code quote:
self.next_txs.clear();31f9d81 to
b86febd
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 5 comments.
Reviewable status: 2 of 3 files reviewed, 5 unresolved discussions (waiting on nimrod-starkware and yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 85 at r1 (raw file):
Previously, nimrod-starkware wrote…
consider moving
commit_state_diffinto the starknet_committer crate. (not in this PR)
I don't think the depndency in starknet_transaction_prover makes sense here...
not sure why this was moved to the prover crate, but we will probably need to depend on this crate soon anyway: need to create a proof-tx to complete the system test blobs
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 197 at r1 (raw file):
Previously, nimrod-starkware wrote…
same as few PR's before.
shouldn'tself.next_txsbe consumed using std::mem::take?
Done.
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 255 at r1 (raw file):
Previously, nimrod-starkware wrote…
see above comment re this.
Done.
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 156 at r1 (raw file):
/// Executes the unblocked transactions and applies the changes to the state. /// Any subsequent tx added will end up in the next block.
Done.
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 57 at r1 (raw file):
use starknet_api::executable_transaction::{ AccountTransaction as ExecutableAccountTx, DeclareTransaction as ExecutableDeclareTransaction,
Done.
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 1 file and all commit messages, made 2 comments, and resolved 5 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).
crates/central_systest_blobs/src/cende_blob_regression_test.rs line 85 at r1 (raw file):
Previously, dorimedini-starkware wrote…
not sure why this was moved to the prover crate, but we will probably need to depend on this crate soon anyway: need to create a proof-tx to complete the system test blobs
oh ok, nvm
b86febd to
eb6a3de
Compare
502ad26 to
ac58318
Compare
eb6a3de to
f5aa05a
Compare
ac58318 to
a2ecdee
Compare
|
Artifacts upload workflows: |
Merge activity
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f5aa05a. Configure here.
f5aa05a to
aecc100
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on yoavGrs).


No description provided.