Skip to content

central_systest_blobs: initial block production#13969

Open
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_sort_hashsets_when_dumpingfrom
04-30-central_systest_blobs_initial_block_production
Open

central_systest_blobs: initial block production#13969
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_sort_hashsets_when_dumpingfrom
04-30-central_systest_blobs_initial_block_production

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Medium Risk
Updates blob/test-data generation and golden JSON fixtures to include real preconfirmed transactions/receipts/state diffs, which may ripple into downstream tests and blob consumers. Also bumps the stored blobs generation used for GCS comparisons.

Overview
Adds initial block production to the central_systest_blobs regression test. The test now builds real bootstrap DECLARE transactions (ERC20 Cairo1 and an account with real validate), closes a block between them, and then finalizes blobs/preconfirmed block output.

Updates expected resources to match the new output. preconfirmed_block.json now reflects block_number: 1 with a populated transaction/receipt/state-diff for the remaining declare, and blob_file_generation is bumped to 6 for the GCS-backed blob snapshot.

Reviewed by Cursor Bugbot for commit 16b1ded. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from f9cb358 to 24bca91 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 1f63202 to 76ca51a Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from 24bca91 to caa4531 Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 76ca51a to 8a32ce9 Compare May 5, 2026 11:56
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from caa4531 to 54e47dc Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 8a32ce9 to 4a1e9a3 Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_sort_hashsets_when_dumping branch from 54e47dc to 1b7ea13 Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_initial_block_production branch from 4a1e9a3 to 16b1ded Compare May 5, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants