Skip to content

central_systest_blobs: deploy test contract(s)#13975

Open
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_declare_the_test_contractfrom
04-30-central_systest_blobs_deploy_test_contract_s_
Open

central_systest_blobs: deploy test contract(s)#13975
dorimedini-starkware wants to merge 1 commit into04-30-central_systest_blobs_declare_the_test_contractfrom
04-30-central_systest_blobs_deploy_test_contract_s_

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 5, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk: updates a regression test’s generated transactions and its golden fixtures; main risk is unintended churn/breakage in downstream blob comparisons if expectations aren’t updated consistently.

Overview
Updates the central_systest_blobs regression-data generator to actually deploy the test contract twice (with fee-charged operator deploy txs), closing blocks between the new steps.

Refreshes the golden artifacts (preconfirmed_block.json) to match the new last-block contents (now an INVOKE_FUNCTION deploy, updated fees/state diffs/nonces) and bumps the stored blob_file_generation value.

Reviewed by Cursor Bugbot for commit 499d09c. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware self-assigned this May 5, 2026
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from 1728354 to d11d08f Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from 4985223 to b6a01a6 Compare May 5, 2026 11:18
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from d11d08f to ee6a2fa Compare May 5, 2026 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from 105ceed to be7907e Compare May 5, 2026 12:31
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from ee6a2fa to 9e4bf26 Compare May 5, 2026 12:31
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on yoavGrs).

@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_deploy_test_contract_s_ branch from 9e4bf26 to 499d09c Compare May 5, 2026 14:17
@dorimedini-starkware dorimedini-starkware force-pushed the 04-30-central_systest_blobs_declare_the_test_contract branch from be7907e to 35e9bfe Compare May 5, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants